An inductively coupled plasma mass spectrometer (ICP-MS) method was established for the determination of 29 elements, such as Be, Al, V, Cr, Mn, Fe, Co, Ni, Cu, Zn, As, Se, Mo, Ru, Pd, Ag, Cd, Sn, Sb, Te, Ba, Nd, Dy, Er, Ir, Hg, Tl, Pb, and U in 23 kinds of traditional Chinese medicines. The samples were digested by nitric acid∶ hydrochloric acid (4∶1) with microwave. The matrix and spectra interference of the ICP-MS were eliminated by online internal standard addition and octopole reaction/collision cell. Normal and helium collision reaction mode were selected for different elements. The RSDs of repeatabilities for 29 elements in different parts of traditional Chinese mdicines were all less than 32.4％. Their average recoveries were in the range of 69.8％ - 121.8％. Their limits of detection were 0.000 3 - 0.609 mg/kg.